Potentiometer symbol

[fai]

@vanepp

Yes this is true. I think (but don’t have proof) that it is even worse in that not always is the same pin used to snap to the grid. I have seen cases were there are pins not on the grid (such as the Uno) where which pin aligns to the grid changes on different loads of the same part. So I agree a common pin as the origin would be a great improvement. I don’t think this is under consideration though as the issue has been closed.

I have opened an issue in the bug tracker. If you know how to replicate the part that changes its alignment on different loads, feel free to post it.

@microMerlin

Adding resources.xml to the mix could have changed the ‘rules’. It was not part of what I looked at before. Without that, I did not see any doubled entries in inspector, even when there was a mix of case in the fzp files.

It could be. First, I changed all the properties to start with a lower case in the resources.xml and in the new parts. This worked well for new parts. However, when using old parts and going through the obsoleting mechanism, the parts got their old properties (which started with an upper case letter). So, probably Fritzing is not handling well this corner case. Finally, I left all the properties starting with an upper case letter (both in resources.xml and properties).

@microMerlin

I assume that the “upgrading” was done through Fritzing offering a replacement for an obsoleted part. The automatic replacement there should position the new part based on one of the connectors common to both the old and new parts. However, as vanepp suggests, it could be getting mixed up with the origin of the svg file.

Yes, I used the upgrade menu that appears after you open a sketch with obsolete parts. I did not see that Fritzing positions the parts based on the connectors. It always keeps the upper left corner of the svg file.

@microMerlin

Are both the old and the new svg connector pins at 0.1 in spacing? If the new is but the old was slightly off, I think you might see this symptom. Earlier testing trying to fix a part with (among other things) small spacing issues through obsolete and update found that if the position of the new and old connector pins where not quite close enough, Fritzing would not automatically connect them. Even though a move of the part, away and back, would then connect. Though what I remember, it should have added a wire to compensate as seen in other samples.

This seems a bug in the swapping mechanism. I open a bug here

@microMerlin

The logic used for swapping parts through inspector is (seems to be) quite different from what is used for obsolete and update to new versions. Both seem to ignore any grid settings. (At least) Inspector uses the graphic origin of the svg, then adds (or move ends of) wires or ratsnest. With the size change, based on the graphic origin, the connectors moved away from the original breaboard holes, so wires were added. The wires on the bottom pins connected to the origial breadboard holes. The logic is not smart enough to notice that the other holes are closer and equivalent.

At the beginning, I thought that it was a bug in the obsoleting mechanism, but I could replicate this bug when swapping a part. So, I just think that the obsoleting mechanism is just triggering a swap.

@microMerlin

@vanepp

That was likely caused (although I haven’t checked!) because the origin of the original part was not X 0 Y 0. I normally do (in Inkscape!) and Edit->select all, then Edit->resize page to selection to set the origin X and Y to 0 0.

I do the equivalent. Part SVG files should have the origin at 0,0. I remember discusion of problems that seemed to be tied to other cases. I have not seen them, because my process always ends up with 0,0 origins.

Yes, I agree that the svgs should start at 0,0. However, this fix in the part will cause to add wires in the breadboard and (likely) remove wires from the schematic view, changing a lot the sketch. I am wondering if this fix is worth it right now. Would it cause severe problems? I can see three options. The first one would be to leave the offset in this part to do not mess the sketches of the users. Potentiometers are common parts and it could be painful to clean the sketch after the update. Another option would be to comment the replacedby attribute in the old part. This would not trigger the update mechanism. We could uncomment it once the origin in the connectors feature is implemented and the bug with the sapping mechanism fixed. Thus, the new potentiometers added to the sketch will use the new parts and the sketches with old potentiometers will still use the old parts. Finally, we could fix the part and force the users to clean up the sketch after the upgrade. If so, I think it would a good idea to specify which parts will be upgraded, see issue here. @KjellM , what do you think is the best strategy?