Power supply symbols help

#1

Hi @vanepp ,
I am working on extending the simulator for transitory analysis and I realized that the different power supplies have some issues and they are very heterogeneous. I could use your expertise with SVGs and Fritzing conventions if you are up to it.

The battery part in core is ok, but it is rotated 90 degrees, which is not the common way of writing electronics (power at the top and ground at the bottom). This forces to rotate the part (which is annoying for advanced users) or contributes to creating “ugly” schematics by beginners, see power supplies need to be oriented vertically · Issue #372 · fritzing/fritzing-parts · GitHub

The DC power (sch part only) is not aligned with the grid correctly and has a problem with the wires connecting in the middle of the connectors. See also SCH DC Power: wires from the center of the connectors · Issue #342 · fritzing/fritzing-parts · GitHub
image

There is also an AC power supply (add a dc power supply and change it to AC), but this part does not align well vertically with the grid and connects not at the end of the connector:
image

I also made a pulse power supply, but it is based on the battery and it is rotated.
dcpower_pulse

It would be great if you could fix the problems, homogenize all the parts (e.g., now the pulse and the ac power supplies have different circle diameters) and use the Fritzing conventions. I have the fpz files, I just need the svgs. And we will not obsolete the parts, they will be new parts to avoid problems with the obsoleting mechanism.
Cheers,
Andres

#2

This looks to be a code problem. The usual answer is that terminalId isn’t set in either the svg or fzp file. Here both are set correctly but don’t work. I expect that is because there is special code triggered by the special moduleId “moduleId=“DC2PowerModuleID””
because there doesn’t seem to be any other cause for it. Here is a copy of the dc_powersupply.svg rescaled and updated to meet the graphics standards, but the misalignment still occurs making me think there is an error in the code somewhere that is suppressing the terminalIds.

dc_powersupply

edit:

I have made 3 individual parts that work as expected so perhaps I just screwed up the installation in core parts.

capture
capture1073×869 94.9 KB

all three are the same size and correctly aligned and meet the graphics standards (if you have fzp file you probably just want the svg files!) One had the svg dimensioned in px which will typically break things, all these are in inches.

ac_powersupply.fzpz (1.8 KB)

pulse_powersupply.fzpz (1.8 KB)

dc_powersupply.fzpz (1.9 KB)

edit2:

Looks like I indeed did something wrong on the first try. I just replaced the current svg with my new svg for the battery and it now aligns correctly so if you take the svgs from the above fzpz files you should be fine.

Peter